revisit: add timeout parameter to cli and driver#3585
Closed
avoidik wants to merge 1 commit intodocker:masterfrom
Closed
revisit: add timeout parameter to cli and driver#3585avoidik wants to merge 1 commit intodocker:masterfrom
avoidik wants to merge 1 commit intodocker:masterfrom
Conversation
Signed-off-by: Viacheslav Vasilyev <avoidik@gmail.com>
Author
|
Same as before:
Defaults: Driver timeout is |
Author
|
kindly asking for your attention to this PR @tonistiigi |
Author
|
cc @CamJN please review too |
crazy-max
reviewed
Feb 23, 2026
| timeoutDuration = defaultTimeoutCli | ||
| } | ||
| } | ||
| flags.DurationVar(&options.timeout, "timeout", timeoutDuration, "Override the default global timeout (as duration, for example 1m20s)") |
Member
There was a problem hiding this comment.
This adds a persistent --timeout flag, so docs now show it for almost every subcommand. But code only consumes it in a subset like create, du. A global timeout flag is not the right UX/API imo. It is too broad for what the implementation actually affects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is to revisit unfinished work to bring consistent timeout across all commands: