Update parameter references from 'Id' to 'UUId' in comment endpoints fixes #23#24
Open
yehonatan1202 wants to merge 1 commit intodirectus:mainfrom
Open
Update parameter references from 'Id' to 'UUId' in comment endpoints fixes #23#24yehonatan1202 wants to merge 1 commit intodirectus:mainfrom
yehonatan1202 wants to merge 1 commit intodirectus:mainfrom
Conversation
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
openapi/paths/comments/_id/updateComment.yaml:5
- The parameter reference was updated to 'UUId', but verify that the component's definition uses a matching name with the path parameter in the endpoint (e.g., if the endpoint path remains /comments/{id}, the parameter's name must align with it or be appropriately overridden).
+ $ref: ../../../components/parameters.yaml#/UUId
openapi/paths/comments/_id/getComment.yaml:5
- The parameter reference was updated to 'UUId', but ensure that the component's definition correctly matches the path parameter used in the URL if it still uses 'id' in the path.
+ $ref: ../../../components/parameters.yaml#/UUId
openapi/paths/comments/_id/deleteComment.yaml:5
- The parameter reference change to 'UUId' should be accompanied by ensuring that the defined parameter name in the components matches the path parameter placeholder in the endpoint path or is properly adjusted.
+ $ref: ../../../components/parameters.yaml#/UUId
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can't really test it but i think this is the solution to
Semantic error at paths./comments/{id} Declared path parameter "id" needs to be defined as a path parameter at either the path or operation level