Conversation
| showCloseButton = false; | ||
|
|
||
| currentActivity: Partial<Activity> = {}; | ||
| TimeLabel: string = ''; |
There was a problem hiding this comment.
I think it will be better to implement Activity (https://github.com/devsecopsmaturitymodel/DevSecOps-MaturityModel/blob/main/src/app/model/activity-store.ts#L45) and use the variable names from the Activity.
There was a problem hiding this comment.
Got It. Will do the necessary changes in a follow up commit. Will resolve this afterwards...
|
Than you @sawankshrma , comments in the review. |
HI @wurstbrot . Thank You for the review. See, this component ( In further iterations I am going to replace this component completely to provide for an Exportable/Printable "Report" page. I hope you understand :) |
2 participants
Description
A new "Report" page is created.
It "dumps" all activities at one page in order to provide it to an auditor, Preferably in a
pdfformat.For now, a slightly modified version of the already existing
ActivityDescriptionComponentis used in this page to display all/some activities on the page. => This is of-course not exportable/printable for now and will be fixed in later iterations.The activities (types, individual) and their attributes are configurable as to what we'd like to show in the report and eventually provide to the auditor. The configurations are stored in the localStorage in the browser like all other informations.
Resolves Issue: #494
What's Changed?
ReportComponentis created which dumps all the activities rendered in a modifiedActivityDescriptionComponentcalledReportConfigModalComponent--> this component is going to be replaced by something better which can be exportable.ReportConfigModalComponent. All the configurations of the report can be altered through this modal. The new configurations are then modified and saved in the localStorage and theReportpage is then re-rendered with those modified configurations.modelfile calledreport-config.tsis created which exports somefunctionsandinterfacesuseful to the "Report" page.app-routing.module.tsandsidenav-buttons.component.tsfiles are modified to contain the new "Report" page.