fix handling of existing prs #13753
Merged
fix handling of existing prs #13753
+286
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brbayes-msft
approved these changes
Dec 11, 2025
...lpers/lib/NuGetUpdater/NuGetUpdater.Core/Run/UpdateHandlers/GroupUpdateAllVersionsHandler.cs
Show resolved
Hide resolved
brettfo
force-pushed
the
dev/brettfo/nuget-ignore-existing
branch
from
8c40126 to
c6f52d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a PR already exists, no call to
create_pull_requestshould be made.Currently this is incorrect as it performs the check only for grouped updates and it does the check too early.
The fix is to check for both grouped and ungrouped but only after an update attempt has been made. This allows for a scenario where a PR exists for
Some.Package/2.0.0but if an update is suddenly possible forSome.Package/2.1.0then it will be created.Fixes #13647.