Skip to content

Conversation

@gmazzo
Copy link
Contributor

@gmazzo gmazzo commented Dec 6, 2025

What are you trying to accomplish?

After #13579, we realised that the executable mode of gradlew was lost when dependabot updates the Gradle Wrapper binaries:

/Users/runner/work/_temp/9c8c4b16-87e9-4ad9-aa50-8fd0b4f2ccd7.sh: line 1: ./gradlew: Permission denied

https://github.com/gmazzo/gradle-codeowners-plugin/actions/runs/19988292200/job/57325370740?pr=251#step:4:21

Smoke tests PR: https://github.com/gmazzo/gradle-codeowners-plugin/pull/251/files

Anything you want to highlight for special attention from reviewers?

I'm assuming that setting file.mode = Mode.EXECUTABLE will be propagated to the PR creation, but needs validation from mantainers.

How will you know you've accomplished your goal?

Since I can't run (or don't know how) to run dependabot locally to open real PRs, I rely on smoke tests to validate the change.

The run with dependabot test reveals that now a new mode: 100755 is added into the output YAML:
image

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@github-actions github-actions bot added the L: java:gradle Maven packages via Gradle label Dec 6, 2025
@gmazzo gmazzo marked this pull request as ready for review December 9, 2025 12:43
@gmazzo gmazzo requested a review from a team as a code owner December 9, 2025 12:43
Copy link
Contributor

@yeikel yeikel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yeikel
Copy link
Contributor

yeikel commented Dec 9, 2025

@kbukum1 Could you please review this?

@kbukum1 kbukum1 self-requested a review December 15, 2025 21:31
@kbukum1
Copy link
Contributor

kbukum1 commented Dec 15, 2025

@gmazzo , sorry for late review. I just saw that in the smoke test the mode is getting updated and accordingly content is getting removed. When we update gradle wrapper and create PR, don't we need also gradlew content as well in the PR or we are not sending update for that?

@kbukum1 kbukum1 moved this to In review in Dependabot Dec 15, 2025
@kbukum1 kbukum1 self-assigned this Dec 15, 2025
@gmazzo
Copy link
Contributor Author

gmazzo commented Dec 16, 2025

Hi @kbukum1!

accordingly content is getting removed.

You mean in the PR diff?

The content of the gradlew was updating already with the previous changes. The issue I spotted now is that the +x flag gests removed with the file update in the PR.

Assuming you are asking about the diff of the smoke tests, the + for the mode: "100755" is for the change in the file attribute that this PR meants to fix.
It's true that there is a - content: "@rem\r\n@rem Copyright 2015 the original author or right after that, but if you take a closer look, that - does not stands for a diff removing, but rather for a YAML entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L: java:gradle Maven packages via Gradle

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

3 participants