Skip to content

Update and refactor models to spec. #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dblock merged 10 commits into from
Oct 20, 2025
Merged

Update and refactor models to spec. #96

dblock merged 10 commits into from
Oct 20, 2025

Conversation

@dblock
Copy link
Owner

@dblock dblock commented Oct 19, 2025

Closes #24.

@dblock dblock force-pushed the refactor-models branch 2 times, most recently from 3db0334 to 4d127b2 Compare October 19, 2025 18:02
@dblock dblock marked this pull request as ready for review October 19, 2025 18:02
@dblock dblock requested a review from simonneutert October 19, 2025 18:02
@dblock
Copy link
Owner Author

dblock commented Oct 19, 2025 •
edited
Loading

@simonneutert This is a big one, mind taking a look if you're around?

@dblock dblock mentioned this pull request Oct 19, 2025
Closed
@simonneutert
Copy link
Collaborator

simonneutert commented Oct 20, 2025

Wow, what a massive effort! 💪 @dblock
I saw that lat/lng implementation was changed here, too, yet was not reflected in this PR. But #98 lists the changes in UPGRADING.md 👏

Incredible how much undocumented stuff Strava carries out 💀

They do not send all properties for non-summit clients - afaik, but this shouldn't break anything.

Skimmed through the changes and everything looks clean and i love that you highlighted undocument and added urls to the models. Is there anything you'd want me to inspect in detail?

I can imagine this could cause a stir, so maybe a warning in v2.x when installing would be something that would be well appreciated.

@dblock
Copy link
Owner Author

dblock commented Oct 20, 2025

Thanks for the quick review @simonneutert! I'll go ahead and merge these PRs. Just keep an eye on the changes please and try them out in your apps.

@dblock dblock merged commit 324ff31 into master Oct 20, 2025
17 checks passed
@dblock dblock deleted the refactor-models branch October 20, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simonneutert simonneutert Awaiting requested review from simonneutert

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

athlete_activities should return [Strava::Models::SummaryActivity] and not [Strava::Models::Activity]

3 participants

@dblock @simonneutert