DAOS-18487 rebuild: don't change dom fseq for MAP_REVERT_REBUILD#17469
Merged
DAOS-18487 rebuild: don't change dom fseq for MAP_REVERT_REBUILD#17469
Conversation
|
Errors are Unable to load ticket data |
Should not change domain's do_comp.co_fseq when revert pool map for rebuild err handling, that may cause do_comp.co_fseq be higher than retried rebuild version and always abort+retry. Signed-off-by: Xuezhao Liu <[email protected]>
liuxuezhao
force-pushed
the
lxz/rb_ver_fix
branch
from
3b7b99e to
cbe1afd
Compare
Collaborator
|
Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17469/2/testReport/ |
NiuYawei
approved these changes
Feb 2, 2026
kccain
reviewed
Feb 2, 2026
| if (status->dtx_resync_version != resync_ver) | ||
| D_INFO(DF_RB " rank %d, update dtx_resync_version from %d to %d", DP_RB_RGT(rgt), | ||
| rank, status->dtx_resync_version, resync_ver); | ||
| D_DEBUG(DB_REBUILD, DF_RB " rank %d, update dtx_resync_version from %d to %d", |
Contributor
There was a problem hiding this comment.
Suggested change
| D_DEBUG(DB_REBUILD, DF_RB " rank %d, update dtx_resync_version from %d to %d", | |
| D_DEBUG(DB_REBUILD, DF_RB " rank %d, update dtx_resync_version from %d to %d\n", |
Contributor
Author
There was a problem hiding this comment.
looks the gurt d_vlog() code will add the "\n" automatically if not provided.
kccain
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should not change domain's do_comp.co_fseq when revert pool map for rebuild err handling, that may cause do_comp.co_fseq be higher than retried rebuild version and always abort+retry.
Steps for the author:
After all prior steps are complete: