Skip to content

Comments

DAOS-17468 control: Prevent start if transparent hugepages are enable…#17457

Merged
daltonbohning merged 4 commits intorelease/2.6from
tanabarr/control-no-thp-rel2_6
Feb 10, 2026
Merged

DAOS-17468 control: Prevent start if transparent hugepages are enable…#17457
daltonbohning merged 4 commits intorelease/2.6from
tanabarr/control-no-thp-rel2_6

Conversation

@tanabarr
Copy link
Contributor

@tanabarr tanabarr commented Jan 26, 2026 •
edited
Loading

…d (#16313)

When THP feature is enabled on linux platforms, SPDK related hugepage management in DAOS performs sub-optimally. Resulting problems relate to memory accounting and fragmentation. To remedy, refuse to start daos_server if THP is enabled on platform and recommend disabling THP by applying kernel commandline parameters effective on reboot.

Features: control

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@tanabarr tanabarr self-assigned this Jan 26, 2026
@tanabarr tanabarr requested review from a team as code owners January 26, 2026 22:56
@github-actions
Copy link

github-actions bot commented Jan 26, 2026

Ticket title is 'Prevent start if transparent hugepages are enabled'
Status is 'Awaiting backport'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-17468

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Jan 26, 2026
@tanabarr
DAOS-17468 control: Prevent start if transparent hugepages are enabled (
da4fdfb 
#16313)

When THP feature is enabled on linux platforms, SPDK related
hugepage management in DAOS performs sub-optimally. Resulting problems
relate to memory accounting and fragmentation. To remedy, refuse to
start daos_server if THP is enabled on platform and recommend
disabling THP by applying kernel commandline parameters effective on
reboot.

Features: control
Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
@tanabarr tanabarr force-pushed the tanabarr/control-no-thp-rel2_6 branch from cba19c2 to da4fdfb Compare January 26, 2026 22:59
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Jan 26, 2026

Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17457/2/testReport/

@tanabarr tanabarr added the unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving. label Jan 29, 2026
@tanabarr
fix unit test
ba24961 
Features: control
Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Jan 30, 2026

Test stage Functional Hardware Large completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-17457/4/display/redirect

1 similar comment
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Jan 30, 2026

Test stage Functional Hardware Large completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-17457/4/display/redirect

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Jan 30, 2026

Test stage Functional Hardware Large completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-17457/5/display/redirect

1 similar comment
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Jan 30, 2026

Test stage Functional Hardware Large completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-17457/5/display/redirect

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Feb 3, 2026

Test stage Functional Hardware Large completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-17457/6/display/redirect

1 similar comment
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Feb 3, 2026

Test stage Functional Hardware Large completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-17457/6/display/redirect

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Feb 3, 2026

Test stage Functional Hardware Large completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-17457/7/display/redirect

1 similar comment
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Feb 3, 2026

Test stage Functional Hardware Large completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-17457/7/display/redirect

@tanabarr
Merge remote-tracking branch 'origin/release/2.6' into tanabarr/contr…
8770769 
…ol-no-thp-rel2_6

Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Feb 6, 2026

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17457/8/testReport/

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Feb 6, 2026

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17457/8/execution/node/1192/log

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Feb 6, 2026

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17457/9/execution/node/412/log

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Feb 6, 2026

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17457/10/execution/node/412/log

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Feb 6, 2026

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17457/11/execution/node/412/log

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Feb 6, 2026

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17457/13/execution/node/574/log

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Feb 6, 2026

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17457/14/execution/node/507/log

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Feb 6, 2026

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17457/15/execution/node/507/log

@tanabarr
Merge remote-tracking branch 'origin/release/2.6' into tanabarr/contr…
5b54fa0 
…ol-no-thp-rel2_6

Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
@tanabarr
Copy link
Contributor Author

tanabarr commented Feb 8, 2026

@knard38 @kjacque could I please get a review on this, thanks.

@tanabarr tanabarr requested review from kjacque and knard38 February 9, 2026 22:26
knard38
knard38 approved these changes Feb 10, 2026
View reviewed changes
Copy link
Contributor

@knard38 knard38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tanabarr tanabarr requested a review from a team February 10, 2026 11:58
@daltonbohning daltonbohning merged commit 62a7346 into release/2.6 Feb 10, 2026
49 checks passed
@daltonbohning daltonbohning deleted the tanabarr/control-no-thp-rel2_6 branch February 10, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knard38 knard38 knard38 approved these changes

@kjacque kjacque Awaiting requested review from kjacque

Assignees

@tanabarr tanabarr

Labels

priority Ticket has high priority (automatically managed) unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tanabarr @daosbuild3 @knard38 @daltonbohning