DAOS-18292 ddb: Debug level of the DDB GO code can not be defined by knard38 · Pull Request #17232 · daos-stack/daos

knard38 · 2025-12-05T09:52:00Z

Description

Properly configure C DAOS debug facilities from Golang DDB code.

Steps for the author:

Commit message follows the guidelines.
Appropriate Features or Test-tag pragmas were used.
Appropriate Functional Test Stages were run.
At least two positive code reviews including at least one code owner from each category referenced in the PR.
Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

Gatekeeper requested (daos-gatekeeper added as a reviewer).

github-actions · 2025-12-05T09:52:16Z

Ticket title is 'Debug level of the DDB GO code can not be defined'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-18292

daosbuild3 · 2025-12-08T03:07:49Z

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17232/1/execution/node/1276/log

daosbuild3 · 2025-12-15T19:27:14Z

Test stage Functional on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17232/2/execution/node/1073/log

daosbuild3 · 2026-01-05T11:07:35Z

Test stage Functional on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-17232/4/display/redirect

daosbuild3 · 2026-01-05T12:25:02Z

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17232/5/testReport/

daosbuild3 · 2026-01-06T07:07:12Z

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17232/5/execution/node/1358/log

daosbuild3 · 2026-01-06T08:21:31Z

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17232/5/execution/node/1399/log

daosbuild3 · 2026-01-29T10:52:58Z

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17232/8/testReport/

daosbuild3 · 2026-01-30T03:51:43Z

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17232/8/execution/node/1398/log

Properly configure C DAOS debug facilities from Golang DDB code. Features: recovery Signed-off-by: Cedric Koch-Hofer <[email protected]>

…/daos-18292

Fix building issue: add missing LD_LIBRARY path. Features: recovery Allow-unstable-test: true Signed-off-by: Cedric Koch-Hofer <[email protected]>

Fix reviewers remarks: - Add short description of VOS path in live help output. Features: recovery Allow-unstable-test: true Signed-off-by: Cedric Koch-Hofer <[email protected]>

Fix reviewers remarks: - Use consistent logging facilities Features: recovery Allow-unstable-test: true Signed-off-by: Cedric Koch-Hofer <[email protected]>

daosbuild3 · 2026-02-16T15:31:43Z

Test stage Functional Hardware Large MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-17232/17/display/redirect

daosbuild3 · 2026-02-17T03:30:07Z

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17232/18/execution/node/1347/log

kjacque

Comments are minor, not something I would block on. Nice improvements! I like the change to pass the log level--this really makes more sense from the perspective of a developer and/or a user collecting logs to troubleshoot.

src/control/cmd/ddb/main.go

…/daos-18292

Fix reviewers remarks: - Improvement of --debug= option help message Features: recovery Allow-unstable-test: true Signed-off-by: Cedric Koch-Hofer <[email protected]>

tanabarr

request for documentation could just be a link to the man page in the source. otherwise LGTM

tanabarr · 2026-02-18T11:09:08Z

src/control/cmd/ddb/main.go

-		setenvIfNotSet("DD_STDERR", "INFO")
-	} else {
-		setenvIfNotSet("DD_STDERR", "ERR")
+func strToLogLevels(level string) (logging.LogLevel, engine.LogLevel, error) {


Would be really helpful to have a good documentation comment here as it has the potential to generate a lot of questions. Explain Why/What/How.

just link man pages it is covered there

Add description comment of the function strToLogLevels()

Add description comment of the function strToLogLevels()

Fixed with commit b0a5e38

…/daos-18292

Fix reviewers remarks: - Add description comment of the function strToLogLevels() Features: recovery Allow-unstable-test: true Signed-off-by: Cedric Koch-Hofer <[email protected]>

Nasf-Fan

Thanks for offering ddb man page that is very useful. It looks fine for me.

knard38 · 2026-02-19T20:48:29Z

Please @daos-stack/daos-gatekeeper could you land this PR with the following message:

title: DAOS-18292 ddb: Fix ddb debugging facilities
body:

Fix ddb debugging facilities and add ddb man page.

knard38 self-assigned this Dec 5, 2025

knard38 force-pushed the ckochhof/fix/master/daos-18292 branch 2 times, most recently from 3df67cc to 85e6a34 Compare December 15, 2025 19:25

knard38 force-pushed the ckochhof/fix/master/daos-18292 branch from 85e6a34 to caf8936 Compare January 5, 2026 08:16

knard38 force-pushed the ckochhof/fix/master/daos-18291 branch 2 times, most recently from 9891709 to 9cbf6fe Compare January 5, 2026 10:58

knard38 force-pushed the ckochhof/fix/master/daos-18292 branch from caf8936 to 72a9f0c Compare January 5, 2026 11:06

knard38 force-pushed the ckochhof/fix/master/daos-18292 branch 2 times, most recently from 795df75 to 0187ab0 Compare January 8, 2026 08:43

knard38 added the CR Catastrophic Recovery Feature label Jan 8, 2026

knard38 force-pushed the ckochhof/fix/master/daos-18292 branch from 0187ab0 to 0f34795 Compare January 29, 2026 08:46

DAOS-18292 ddb: Debug level of the DDB GO code can not be defined

981d4b8

Properly configure C DAOS debug facilities from Golang DDB code. Features: recovery Signed-off-by: Cedric Koch-Hofer <[email protected]>

knard38 force-pushed the ckochhof/fix/master/daos-18292 branch from 0f34795 to 981d4b8 Compare February 6, 2026 14:09

knard38 changed the base branch from ckochhof/fix/master/daos-18291 to master February 6, 2026 14:10

knard38 marked this pull request as ready for review February 6, 2026 14:10

knard38 requested review from a team as code owners February 6, 2026 14:10

knard38 requested review from Nasf-Fan, janekmi, kjacque and tanabarr February 6, 2026 14:11

kanard38 added 2 commits February 16, 2026 09:20

Merge remote-tracking branch 'origin/master' into ckochhof/fix/master…

e28348f

…/daos-18292

DAOS-18292 ddb: Debug level of the DDB GO code can not be defined

cf9ee10

Fix building issue: add missing LD_LIBRARY path. Features: recovery Allow-unstable-test: true Signed-off-by: Cedric Koch-Hofer <[email protected]>

knard38 dismissed kjacque’s stale review via cf9ee10 February 16, 2026 09:22

kanard38 added 2 commits February 16, 2026 09:55

DAOS-18292 ddb: Debug level of the DDB GO code can not be defined

adf4a2d

Fix reviewers remarks: - Add short description of VOS path in live help output. Features: recovery Allow-unstable-test: true Signed-off-by: Cedric Koch-Hofer <[email protected]>

DAOS-18292 ddb: Debug level of the DDB GO code can not be defined

021ee3b

Fix reviewers remarks: - Use consistent logging facilities Features: recovery Allow-unstable-test: true Signed-off-by: Cedric Koch-Hofer <[email protected]>

knard38 requested review from Nasf-Fan and kjacque February 16, 2026 15:34

kjacque previously approved these changes Feb 17, 2026

View reviewed changes

src/control/cmd/ddb/main.go Show resolved Hide resolved

src/control/cmd/ddb/main.go Outdated Show resolved Hide resolved

kanard38 added 2 commits February 18, 2026 09:22

Merge remote-tracking branch 'origin/master' into ckochhof/fix/master…

889363b

…/daos-18292

DAOS-18292 ddb: Debug level of the DDB GO code can not be defined

429f3cb

Fix reviewers remarks: - Improvement of --debug= option help message Features: recovery Allow-unstable-test: true Signed-off-by: Cedric Koch-Hofer <[email protected]>

knard38 dismissed kjacque’s stale review via 429f3cb February 18, 2026 09:26

knard38 requested a review from kjacque February 18, 2026 09:27

tanabarr previously approved these changes Feb 18, 2026

View reviewed changes

kjacque previously approved these changes Feb 18, 2026

View reviewed changes

kanard38 added 2 commits February 19, 2026 07:48

Merge remote-tracking branch 'origin/master' into ckochhof/fix/master…

8ca9cf5

…/daos-18292

DAOS-18292 ddb: Debug level of the DDB GO code can not be defined

b0a5e38

Fix reviewers remarks: - Add description comment of the function strToLogLevels() Features: recovery Allow-unstable-test: true Signed-off-by: Cedric Koch-Hofer <[email protected]>

knard38 dismissed stale reviews from kjacque and tanabarr via b0a5e38 February 19, 2026 07:54

knard38 requested review from kjacque and tanabarr and removed request for tanabarr February 19, 2026 13:00

Nasf-Fan approved these changes Feb 19, 2026

View reviewed changes

tanabarr approved these changes Feb 19, 2026

View reviewed changes

knard38 requested a review from a team February 19, 2026 20:46

daltonbohning merged commit ccc1cd2 into master Feb 19, 2026
46 checks passed

daltonbohning deleted the ckochhof/fix/master/daos-18292 branch February 19, 2026 21:54

Conversation

knard38 commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Steps for the author:

After all prior steps are complete:

Uh oh!

github-actions bot commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daosbuild3 commented Dec 8, 2025

Uh oh!

daosbuild3 commented Dec 15, 2025

Uh oh!

daosbuild3 commented Jan 5, 2026

Uh oh!

daosbuild3 commented Jan 5, 2026

Uh oh!

daosbuild3 commented Jan 6, 2026

Uh oh!

daosbuild3 commented Jan 6, 2026

Uh oh!

daosbuild3 commented Jan 29, 2026

Uh oh!

daosbuild3 commented Jan 30, 2026

Uh oh!

daosbuild3 commented Feb 16, 2026

Uh oh!

daosbuild3 commented Feb 17, 2026

Uh oh!

kjacque left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tanabarr left a comment

Choose a reason for hiding this comment

Uh oh!

tanabarr Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

tanabarr Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

knard38 Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

knard38 Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Nasf-Fan left a comment

Choose a reason for hiding this comment

Uh oh!

knard38 commented Feb 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

7 participants

knard38 commented Dec 5, 2025 •

edited

Loading

github-actions bot commented Dec 5, 2025 •

edited

Loading

knard38 Feb 19, 2026 •

edited

Loading