Allow name to be optional in user models#13
Conversation
WalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
shellrecharge/usermodels.py (1)
20-20: LGTM! Field is now correctly optional.The change properly makes the
namefield optional by allowingNonevalues with a default.Refactor for consistency: Use
Optional[str]instead ofstr | None.The file consistently uses
Optional[T]syntax throughout (lines 26-27, 80-82, 106, 118). For uniformity, useOptional[str] = Noneinstead ofstr | None = None:- name: str | None = None + name: Optional[str] = None
Fix issue #12
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.