Conversation
|
Faced exactly the same issue with openrouter provider |
|
I had been running into issues using Haiku 4.5 at AWS Bedrock while streaming and using tool calls. The way it manifested was the model calling a tool with incorrect parameters. I always had a sneaking suspicion that it wasn't model hallucination because I had never experienced that when I was using the AWS SDK directly instead of RubyLLM. I just applied this patch to my system and my sreaming issues with Haiku seen to have been resolved. this would be great to get merged into core. |
|
Thanks for confirming and for testing this. |
|
Is this error I've just started seeing on local/Ollama related to this PR? I wasn't seeing this about a month ago, maybe a recent Ollama update changed something? If not related, shall I open a new issue? |
What this does
Fixes a streaming crash when tool-call deltas omit
function.argumentsby normalizing nil/empty fragments during accumulation, and adds a regression spec to cover the case.Type of change
Scope check
Required for new features
PRs for new features or enhancements without a prior approved issue will be closed.
Quality check
overcommit --installand all hooks passbundle exec rake vcr:record[provider_name]bundle exec rspecmodels.json,aliases.json)AI-generated code
API changes