Added corbench code without manifest files#2
Added corbench code without manifest files#2TheKongers wants to merge 2 commits intocortexproject:mainfrom
Conversation
TheKongers
force-pushed
the
add-corbench-code-without-manifests
branch
2 times, most recently
from
9ccc8e7 to
d9df051
Compare
| @@ -0,0 +1,16 @@ | |||
| FROM --platform=linux/amd64 golang:1.15-alpine | |||
There was a problem hiding this comment.
Can we use newer version of golang?
| name: gp2-csi | ||
| provisioner: ebs.csi.aws.com | ||
| parameters: | ||
| type: gp2 |
There was a problem hiding this comment.
I could use gp3, but i wonder if it will break, i will give it a test
| @@ -0,0 +1,18 @@ | |||
| # Build stage | |||
| FROM golang:1.15-alpine AS builder | |||
|
|
||
| type Resource = provider.Resource | ||
|
|
||
| type eksCluster struct { |
There was a problem hiding this comment.
Do we really need these code? Can we just import prombench as a library
| "github.com/cortexproject/test-infra/corbench/pkg/provider" | ||
| ) | ||
|
|
||
| func init() { |
There was a problem hiding this comment.
ditto. If we cannot reuse prombench CLI, let's try to use its library instead of copy its code directly.
| set -e | ||
|
|
||
| # Disable AWS CLI pager to prevent interactive prompts | ||
| export AWS_PAGER="" |
There was a problem hiding this comment.
It is ok to keep this script for now but we should try to just configure EBS CSI addon in the same eks cluster yaml
There was a problem hiding this comment.
I will add a note
Signed-off-by: Eric Kong <[email protected]>
Signed-off-by: Eric Kong <[email protected]>
TheKongers
force-pushed
the
add-corbench-code-without-manifests
branch
from
7b7312f to
4b48209
Compare
|
Hi ben! I would like to continue getting this in the repo when I have some spare time, but I don't have resources for testing changes anymore, Is there some way I could get aws credits? |
|
@yeya24 anything blocking us from merging this code for now? |
2 participants
Moved over all corbench code from https://github.com/TheKongers/Corbench without the manifest files.
NOTE: the files under the directories
/corbench/infraand/corbench/pkgare directly from prombench, but trimmed down to only keep the EKS functionality to make it more lightweight.