Add source label (rw1/rw2) to incoming/received data#7237
Open
SungJin1212 wants to merge 3 commits intocortexproject:masterfrom
Open
Add source label (rw1/rw2) to incoming/received data#7237SungJin1212 wants to merge 3 commits intocortexproject:masterfrom
SungJin1212 wants to merge 3 commits intocortexproject:masterfrom
Conversation
Signed-off-by: SungJin1212 <[email protected]>
dosubot
bot
added
component/distributor
type/observability
Signed-off-by: SungJin1212 <[email protected]>
Signed-off-by: SungJin1212 <[email protected]>
yeya24
reviewed
Jan 30, 2026
| enum SourceEnum { | ||
| API = 0; | ||
| RULE = 1; | ||
| API_V2 = 2; |
Contributor
There was a problem hiding this comment.
For me I think API v2 is not another source. It should be still API source
| Name: "distributor_received_samples_total", | ||
| Help: "The total number of received samples, excluding rejected and deduped samples.", | ||
| }, []string{"user", "type"}), | ||
| }, []string{"user", "type", "source"}), |
Contributor
There was a problem hiding this comment.
Personally I don't really have a usecase to keep track of received samples or other data types per source.
Is it sufficient to keep track of number of remote write v2 vs v1 requests?
Member
Author
There was a problem hiding this comment.
That sounds right, just counting requests enough for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
sourcelabel to Distributor to distinguish between Prometheus Remote Write v1 and v2 traffic. As we start adopting PRW v2, observability into the traffic per protocol version becomes necessary.he following metrics now have a new source label with values
rw1,rw2, orrule:Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]