Refactor: Delete duplicate ha tracker config in distributor#7235
Open
SungJin1212 wants to merge 1 commit intocortexproject:masterfrom
Open
Refactor: Delete duplicate ha tracker config in distributor#7235SungJin1212 wants to merge 1 commit intocortexproject:masterfrom
SungJin1212 wants to merge 1 commit intocortexproject:masterfrom
Conversation
Signed-off-by: SungJin1212 <[email protected]>
SungJin1212
force-pushed
the
Refactor-delete-haConfig-in-distributor
branch
from
4426e9c to
a50fbf6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the redundant
distributor_ha_tracker.gofile and refactors the Distributor to use the sharedHATrackerConfigfrom thepkg/hapackage directly.Additionally, this PR improves the clarity HA Tracker configuration flags and documentation.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]