feat: add type label to cortex_discarded_samples_total metric (#6221)#7183
Open
ANAMASGARD wants to merge 1 commit intocortexproject:masterfrom
Open
feat: add type label to cortex_discarded_samples_total metric (#6221)#7183ANAMASGARD wants to merge 1 commit intocortexproject:masterfrom
ANAMASGARD wants to merge 1 commit intocortexproject:masterfrom
Conversation
Add a 'type' label to the cortex_discarded_samples_total metric to distinguish between float and native histogram samples. - type="float" for regular float samples - type="histogram" for native histogram samples This helps operators identify whether discarded samples are floats or native histograms, improving observability for debugging ingestion issues. Fixes cortexproject#6221 Signed-off-by: Gauarv Chaudhary <chaudharygaurav2004@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds a
typelabel to thecortex_discarded_samples_totalmetric to distinguish between float and native histogram samples.type="float"for regular float samplestype="histogram"for native histogram samplesThis enhancement helps operators identify whether discarded samples are floats or native histograms, improving observability when debugging data ingestion issues.
Which issue(s) this PR fixes
Fixes #6221
Changes
pkg/util/validation/validate.go
SampleTypeFloat = "float"andSampleTypeHistogram = "histogram"constantsdiscardedSamplesmetric definition to include"type"labelDiscardedSamples.WithLabelValuescalls in ValidateSampleTimestamp, ValidateLabels, and ValidateNativeHistogram functionspkg/ingester/ingester.go
DiscardedSamples.WithLabelValuescalls with appropriate sample typespkg/distributor/distributor.go
DiscardedSamples.WithLabelValuescallspkg/util/validation/validate_test.go
typelabelCHANGELOG.md
Checklist
Breaking Change Notice
Migration Example