Merged
Conversation
kd7lxl
requested changes
Dec 18, 2025
Collaborator
kd7lxl
left a comment
kd7lxl
left a comment
There was a problem hiding this comment.
Great stuff. I'm excited to try out parquet storage.
SungJin1212
force-pushed
the
Add-parquet-converter
branch
from
fbf87d3 to
9195829
Compare
kd7lxl
reviewed
Dec 18, 2025
values.yaml
Outdated
Comment on lines
1293
to
1297
| # -- arbitrary snippet to inject in the http {} section of the nginx config | ||
| httpSnippet: "" | ||
| # -- arbitrary snippet to inject in the top section of the nginx config | ||
| mainSnippet: "" | ||
| # -- arbitrary snippet to inject in the server { } section of the nginx config | ||
| # -- arbitrary snippet to inject in the server {} section of the nginx config |
Collaborator
There was a problem hiding this comment.
I still see unrelated changes to these lines. Please no changes outside the scope of the PR.
Member
Author
There was a problem hiding this comment.
I just updated the PR. Thanks
Member
Author
|
@kd7lxl |
Collaborator
|
Please address all the comments before re-requesting review. |
SungJin1212
force-pushed
the
Add-parquet-converter
branch
from
1bfa34b to
2f00854
Compare
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
SungJin1212
force-pushed
the
Add-parquet-converter
branch
from
2f00854 to
e8cf7f6
Compare
kd7lxl
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a parquet converter.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX],[DEPENDENCY]