fix: handle non-file URI schemes in runTerminalCommand for WSL2 #9325
+270
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fileURLToPath function can throw "The URL must be of scheme file" in some WSL2/remote environments with malformed URIs. Wrap in try-catch to fall through to HOME directory fallback. Fixes continuedev#8091 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
shanevcantwell
requested review from
RomneyDa
and removed request for
a team
Contributor
Learn moreAll Green is an AI agent that automatically: ✅ Addresses code review comments ✅ Fixes failing CI checks ✅ Resolves merge conflicts |
dosubot
bot
added
the
size:XS
Parse vscode-remote://wsl+distro/path URIs to extract the actual workspace path instead of falling back to Windows HOME directory. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
dosubot
bot
added
size:S
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="core/tools/implementations/runTerminalCommand.ts">
<violation number="1" location="core/tools/implementations/runTerminalCommand.ts:58">
P2: The `url.pathname` returns URL-encoded strings (e.g., `/home/user/my%20project` instead of `/home/user/my project`). Workspace paths containing spaces or special characters will fail because the encoded path doesn't exist on the filesystem. Use `decodeURIComponent(url.pathname)` to match the decoding behavior of `fileURLToPath()` used for file:// URIs.</violation>
</file>
Reply to cubic to teach it or ask questions. Tag @cubic-dev-ai to re-run a review.
Paths with spaces or special characters (e.g., /home/user/my%20project) need decodeURIComponent() to match actual filesystem paths. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Tests cover: - Basic WSL URI parsing - URL-encoded spaces and special characters - Unicode path handling - Different WSL distro names - Priority of WSL URIs over file:// URIs - Fallback behavior - Edge cases (plus signs, percent signs, mixed encoding) - Comparison with fileURLToPath behavior 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
dosubot
bot
added
size:L
Contributor
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="core/tools/implementations/resolveWorkingDirectory.vitest.ts">
<violation number="1" location="core/tools/implementations/resolveWorkingDirectory.vitest.ts:133">
P2: Environment variable modification should use `afterEach` or `try/finally` to ensure cleanup runs even if assertions fail. If this test fails, `process.env.HOME` remains set to `/test/home`, potentially causing flaky behavior in subsequent tests.</violation>
</file>
Reply to cubic to teach it or ask questions. Tag @cubic-dev-ai to re-run a review.
Ensures process.env.HOME is restored even if assertions fail, preventing flaky behavior in subsequent tests. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Documents workarounds for: - Building VSIX from WSL2 (extension host selection) - File count issues affecting activation - Terminal command working directory resolution 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
shanevcantwell
force-pushed
the
fix/wsl2-terminal-command-uri
branch
from
d88cbc5 to
6b30a88
Compare
Author
|
Before & after for reference. (With PR #9314 fix.) (gpt-oss-20b) |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When running
run_terminal_commandin WSL2, it crashes with:Root Cause
The
resolveWorkingDirectoryfunction inrunTerminalCommand.tscallsfileURLToPath()on workspace URIs. In WSL2/remote environments,getWorkspaceDirs()can return URIs likevscode-remote://wsl+Ubuntu/pathinstead offile:///path. ThefileURLToPathfunction throws when the scheme isn'tfile://.Fix
Wrap the
fileURLToPathcall in a try-catch so it falls through to the existing HOME directory fallback instead of crashing. This is a minimal, defensive change - 5 lines added.Fixes #8091
Test plan
🤖 Generated with Claude Code
Summary by cubic
Fixes a crash in runTerminalCommand on WSL2 by resolving vscode-remote://wsl URIs to local paths and safely handling non-file workspace URIs. Falls back to HOME when resolution fails.
Written for commit 6b30a88. Summary will update automatically on new commits.