fix(logs): improve timestamp precision in container logs #27696
+36
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MayorFaj <[email protected]>
github-actions
bot
added
the
kind/api-change
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Signed-off-by: MayorFaj <[email protected]>
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Signed-off-by: MayorFaj <[email protected]>
MayorFaj
force-pushed
the
fix-logs-timestamp-precision
branch
from
e1e955d to
e28d1e5
Compare
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Member
|
if we are following docker behavior, then its likely not a bug. else, LGTM at quick glance. |
At least in the Docker API v1.51 running on my local machine, I get nanosecond precision. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Honny1, MayorFaj The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Member
|
/packit retest-failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #27691in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?
Fixes #27691
This pull request updates the timestamp formatting in container logs to provide higher precision.
pkg/api/handlers/compat/containers_logs.go, the timestamp format for log entries was changed fromtime.RFC3339totime.RFC3339Nano, allowing log timestamps to include nanosecond precision.