Skip to content

Conversation

@AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Dec 23, 2025

Hayato Kiwata (@haytok) has been very actively contributing to the project:
https://github.com/containerd/nerdctl/issues?q=is%3Apr+author%3Ahaytok

So I'd like to invite him as a reviewer

Needs explicit LGTM from the candidate and 1/3 of the nerdctl Committers ( $ceil \left( 5 \times \frac{1}{3} \right) = 2$ ), according to
https://github.com/containerd/project/blob/main/GOVERNANCE.md :

After a candidate has been informally proposed in the maintainers forum, the existing maintainers are given seven days to discuss the candidate, raise objections and show their support. Formal voting takes place on a pull request that adds the contributor to the MAINTAINERS file. Candidates must be approved by 2/3 of the current committers by adding their approval or LGTM to the pull request. The reviewer role has the same process but only requires 1/3 of current committers.

If a candidate is approved, they will be invited to add their own LGTM or approval to the pull request to acknowledge their agreement. A committer will verify the numbers of votes that have been received and the allotted seven days have passed, then merge the pull request and invite the contributor to the organization.

For non-core sub-projects, only committers of the repository that the candidate is proposed for are given votes.

Candidate:

nerdctl Committers:

Core Committers (non-binding)

I'd also like to get a few LGTMs from other Core Committers too. (not necessary)

This PR will remain open for 7 days.

@AkihiroSuda AkihiroSuda added this to the v2.3.0 milestone Dec 23, 2025
Copy link
Member

@ktock ktock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, welcome.

@yankay
Copy link
Contributor

yankay commented Dec 24, 2025

welcome. 👍 LGTM

Copy link
Member

@djdongjin djdongjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, welcome!

@haytok
Copy link
Contributor

haytok commented Dec 24, 2025

LGTM :)

Thank you very much for inviting me to be a reviewer — I’m truly honored.
I really appreciate everyone’s continued support, and I’ll do my best to contribute more through reviews and commits going forward.

Copy link
Member

@fahedouch fahedouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome :)

Copy link
Member

@Zheaoli Zheaoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants