Release Candidate 2.13.2#2201
Conversation
Pratyush Ranjan (PratRanj07)
requested review from
a team and
Matthew Seal (MSeal)
as code owners
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Pull request overview
Updates the project to the 2.13.2 release-candidate line by bumping the Python package version and the librdkafka version expectations/pins used for builds.
Changes:
- Bump confluent-kafka-python version to
2.13.2rc1(C extension +pyproject.toml). - Raise the minimum required librdkafka version check/messages to
v2.13.2. - Update CI and example Docker build pins to use
v2.13.2-RC1.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/confluent_kafka/src/confluent_kafka.h |
Updates client version string and minimum required librdkafka version/messages. |
pyproject.toml |
Updates Python package version to 2.13.2rc1. |
examples/docker/Dockerfile.alpine |
Pins Docker build to librdkafka v2.13.2-RC1. |
.semaphore/semaphore.yml |
Pins CI wheel builds to librdkafka v2.13.2-RC1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| env_vars: | ||
| - name: LIBRDKAFKA_VERSION | ||
| value: v2.13.0 | ||
| value: v2.13.2-RC1 |
There was a problem hiding this comment.
This pins LIBRDKAFKA_VERSION to v2.13.2-RC1 while the C extension’s minimum required librdkafka version/error messages were updated to v2.13.2. Please align the CI librdkafka version with the in-source minimum version check (either use the final v2.13.2 here, or update the in-source minimum version to accept the RC build).
| value: v2.13.2-RC1 | |
| value: v2.13.2 |
| COPY . /usr/src/confluent-kafka-python | ||
|
|
||
| ENV LIBRDKAFKA_VERSION="v2.13.0" | ||
| ENV LIBRDKAFKA_VERSION="v2.13.2-RC1" |
There was a problem hiding this comment.
This Dockerfile now builds against librdkafka tag v2.13.2-RC1, but the code’s minimum required librdkafka version check was bumped to v2.13.2. Please keep the Docker build pinned to a librdkafka version that satisfies the in-source minimum version gate (final v2.13.2 when available, or update the min-version constant/messages to accept the RC tag used here).
| ENV LIBRDKAFKA_VERSION="v2.13.2-RC1" | |
| ENV LIBRDKAFKA_VERSION="v2.13.2" |
| #define MIN_RD_KAFKA_VERSION 0x020d02ff | ||
|
|
||
| #ifdef __APPLE__ | ||
| #define MIN_VER_ERRSTR \ | ||
| "confluent-kafka-python requires librdkafka v2.13.0 or later. " \ | ||
| "confluent-kafka-python requires librdkafka v2.13.2 or later. " \ | ||
| "Install the latest version of librdkafka from Homebrew by running " \ | ||
| "`brew install librdkafka` or `brew upgrade librdkafka`" | ||
| #else | ||
| #define MIN_VER_ERRSTR \ | ||
| "confluent-kafka-python requires librdkafka v2.13.0 or later. " \ | ||
| "confluent-kafka-python requires librdkafka v2.13.2 or later. " \ | ||
| "Install the latest version of librdkafka from the Confluent " \ | ||
| "repositories, see http://docs.confluent.io/current/installation.html" | ||
| #endif | ||
|
|
||
| #if RD_KAFKA_VERSION < MIN_RD_KAFKA_VERSION | ||
| #ifdef __APPLE__ | ||
| #error \ | ||
| "confluent-kafka-python requires librdkafka v2.13.0 or later. Install the latest version of librdkafka from Homebrew by running `brew install librdkafka` or `brew upgrade librdkafka`" | ||
| "confluent-kafka-python requires librdkafka v2.13.2 or later. Install the latest version of librdkafka from Homebrew by running `brew install librdkafka` or `brew upgrade librdkafka`" | ||
| #else | ||
| #error \ | ||
| "confluent-kafka-python requires librdkafka v2.13.0 or later. Install the latest version of librdkafka from the Confluent repositories, see http://docs.confluent.io/current/installation.html" | ||
| "confluent-kafka-python requires librdkafka v2.13.2 or later. Install the latest version of librdkafka from the Confluent repositories, see http://docs.confluent.io/current/installation.html" |
There was a problem hiding this comment.
The minimum required librdkafka version is set to v2.13.2 (0x020d02ff) and the user-facing error strings also say "v2.13.2 or later", but the repo’s CI/Docker configs in this PR are pinned to the librdkafka release-candidate tag v2.13.2-RC1. These should be kept consistent: either (a) update CI/Docker to use the final v2.13.2 tag/redist once available, or (b) adjust MIN_RD_KAFKA_VERSION (and the messages) to allow the v2.13.2-RC1 build-time/runtime version so RC builds don’t get rejected by the version gate.
|
No description provided.