feat: complete Superglobals implementation

[michalsn]

Description
This PR completes the implementation of the Superglobals class and migrates the entire codebase to use it consistently.

I started work on this about a month ago, and it turned out to be a tedious task. The scope of changes is relatively large, as this migration could not be done incrementally.

Since this class is internal and not intended for end-user consumption, no changelog entry has been added.

See: #7866

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[neznaika0]

I patched the latest commit 4.7 - there is an error.

1) CodeIgniter\Models\PaginateModelTest::testMultiplePager
Failed asserting that '<!-- DEBUG-VIEW START 1 SYSTEMPATH/Pager/Views/default_full.php -->\n
...
<!-- DEBUG-VIEW ENDED 1 SYSTEMPATH/Pager/Views/default_full.php -->\n
' [ASCII](length: 843) contains "?page_valid=1"" [ASCII](length: 14).

/development/tests/system/Models/PaginateModelTest.php:103

A lot of changes - I couldn't see them all at once.

UPD: Fixes #9392

[paulbalandan]

Can we use constructor property promotion here and instead of null default we use directly the superglobals.

Suggested change

	public function __construct(
	?array $server = null,
	?array $get = null,
	?array $post = null,
	?array $cookie = null,
	?array $files = null,
	?array $request = null,
	) {
	$this->server = $server ?? $_SERVER;
	$this->get = $get ?? $_GET;
	$this->post = $post ?? $_POST;
	$this->cookie = $cookie ?? $_COOKIE;
	$this->files = $files ?? $_FILES;
	$this->request = $request ?? $_REQUEST;
	}
	public function __construct(
	private array $server = $_SERVER,
	private array $get = $_GET,
	private array $post = $_POST,
	private array $cookie = $_COOKIE,
	private array $files = $_FILES,
	private array $request = $_REQUEST,
	) {
	}

[michalsn]

Sadly, we can't do that with superglobals, but I introduced property promotion.

[paulbalandan]

For the getters, how about the idea of introducing a default parameter, liked mixed $default = null so that on invocation we can define already the default value in case missing instead of doing ?? <default>?

[michalsn]

Done.

[paulbalandan]

There's currently a disconnect in this PR for the types a superglobal can set vs the types it can get. The set types is currently less precise than the get types. To make sync easier, I suggest to add phpstan-types in the class declaration phpdoc for each superglobal, something like:

/**
 * @phpstan-type server_items array<array-key, mixed>|float|int|string
 * etc.
 */
class Superglobals

Then here and the setters and getters below we can simply plug the phpstan type, like so:

Suggested change

	* @param array<string, array|float|int|string>|null $server
	* @param array<string, server_items>|null $server

[michalsn]

Done... I think. Please verify when you have time.

[michalsn]

@neznaika0 What do you mean by saying "I patched the latest commit 4.7"? Have you cloned this branch and run tests locally? This branch is working on the latest 4.7.

Anyway, I found the potential issue and hopefully fixed it. The strange thing is that it didn't pop up during tests.

[neznaika0]

@michalsn I use few git features - it's easy to lose changes. I downloaded https://github.com/codeigniter4/CodeIgniter4/pull/9858.patch and I applied it on 4.7 at local.

[michalsn]

@neznaika0 Ok, please verify if the issue still exists after recent changes - thanks.

[neznaika0]

We have an mixed argument, since this should match server_items (and other places), you can add PHPDoc.

I'm sorry if this looks like a complication. You can leave it as it is

[neznaika0]

Good. Error is missing