feat: Fully support Events API v2 in PagerDuty step#697
Open
kiyanmair wants to merge 11 commits intocodefresh-io:masterfrom
Open
feat: Fully support Events API v2 in PagerDuty step#697kiyanmair wants to merge 11 commits intocodefresh-io:masterfrom
kiyanmair wants to merge 11 commits intocodefresh-io:masterfrom
Conversation
Author
|
@dustinvanbuskirk @lrochette Hey folks! 👋 Any chance you can take a look at this PR? |
Contributor
|
I alerted our Dev team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
eventvalue to thePAGERDUTY_ALERT_TYPEenum.PAGERDUTY_SEVERITYargument.Why
Notes
triggerevent action, notacknowledgeorresolve, because they add complexity to the step and I'm not sure they're useful in the Codefresh context.