fix: run-workers --by suite parallelization broken by test file sorting#5418
Closed
mirao wants to merge 1 commit intocodeceptjs:3.xfrom
Closed
fix: run-workers --by suite parallelization broken by test file sorting#5418mirao wants to merge 1 commit intocodeceptjs:3.xfrom
mirao wants to merge 1 commit intocodeceptjs:3.xfrom
Conversation
…ng (codeceptjs#5412) The sorting of test files in loadTests() (added in codeceptjs#5386) broke the --by suite parallelization. When files were sorted before worker distribution, all workers could receive the same tests instead of different suites being distributed to different workers. Fix: Move testFiles.sort() from loadTests() to run(). This ensures: - Worker distribution uses original (unsorted) file order for consistent distribution across workers - Test execution still uses alphabetical order (sorted in run()) Added unit test to verify files are not sorted after loadTests(). Fixes codeceptjs#5412 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5412 -
run-workers --by suiteparallelization was broken by PR #5386 which added test file sorting.The Problem
When
this.testFiles.sort()was added toloadTests(), it changed the order of test files before worker distribution. This caused the--by suiteparallelization to break - all workers could receive the same tests instead of different suites being distributed to different workers.The Fix
Move
testFiles.sort()fromloadTests()torun(). This ensures:run()) as intended by Ensure test files are executed in alphabetical order #5386Changes
this.testFiles.sort()fromloadTests()torun()run()loadTests()(the key fix for Run-workers: Parallelization per suite doesn't work in specific case in 3.7.6 #5412)Test Plan
loadTests()🤖 Generated with Claude Code