Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces runtime-status reporting for adapters by adding an Aquila runtime status gRPC client and wiring it into the base ServerRunner, with adapters now providing runtime metadata (features/configuration) at startup.
Changes:
- Add
DracoRuntimeStatusServiceclient to update adapter runtime status (NotReady/Running/Stopped) against Aquila. - Extend
ServerRunner::serveto acceptRuntimeFeatureandAdapterConfigurationvectors and trigger status updates during lifecycle. - Update REST and Cron adapters to pass runtime features/configuration; REST adapter also changes expected header result shape to a struct/map.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/base/src/runner.rs | Extends server lifecycle to publish runtime status updates and exposes server config getter. |
| crates/base/src/lib.rs | Exposes new client module from the base crate. |
| crates/base/src/client/mod.rs | Adds Aquila gRPC client with retrying channel creation and runtime status update helpers. |
| adapter/rest/src/main.rs | Passes runtime metadata into runner; adjusts flow header parsing to struct/map shape. |
| adapter/cron/src/main.rs | Passes runtime feature metadata into runner at startup. |
Comments suppressed due to low confidence (1)
adapter/rest/src/main.rs:220
- The error message says "headers was not a list of header entries", but this code now expects
headersto be aStruct(map) of string->string. Update the message to match the new expected shape to make debugging flow outputs easier.
// headers struct
let Value {
kind:
Some(Kind::StructValue(Struct {
fields: header_fields,
})),
} = headers_val
else {
return json_error(
StatusCode::INTERNAL_SERVER_ERROR,
"headers was not a list of header entries",
);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <[email protected]> Signed-off-by: Raphael Götz <[email protected]>
Co-authored-by: Copilot Autofix powered by AI <[email protected]> Signed-off-by: Raphael Götz <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #127