Run tests on PHP 8.3 and update test suite#113
Conversation
SimonFrings
left a comment
SimonFrings
left a comment
There was a problem hiding this comment.
Thanks for filing this pull request 👍
I added a few remarks below, should both be quick fixes.
I also noticed that the test suite currently reports unhandled promise rejections in this project (see reactphp/promise#248 and https://github.com/orgs/reactphp/discussions/525 for reference), but I think this is something for a follow-up PR. I will look into this.
SimonFrings
added
documentation
|
Tysm @SimonFrings for seeing both mistakes! Helps me a lot for the future. 🥳 Should be alright now! |
SimonFrings
left a comment
SimonFrings
left a comment
There was a problem hiding this comment.
Thanks for applying the changes, looking good 👍
yadaiio
force-pushed
the
test_suite
branch
2 times, most recently
from
38cc452 to
233e5db
Compare
yadaiio
force-pushed
the
test_suite
branch
2 times, most recently
from
75372bb to
83dce2a
Compare
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@yadaiio Thanks for filing this PR!
I've updated the PR to no longer report any deprecations as reported in #114. This PR now no longer reports any test errors and focuses on adding PHP 8.3 only.
I'll file separate follow-up PRs to address the deprecations reported in #114 and the unhandled promise rejections reported in #115.
|
Thank you @clue for the update 👍 |
3 participants
This pull request builds on top of #108 #107 and #105.
References: clue/reactphp-csv#33, reactphp/socket#300 and reactphp/socket#299.
After this pull request is merged, we can continue with #112