Run tests on PHP 8.3 and update test suite#54
Merged
Conversation
SimonFrings
suggested changes
Nov 14, 2023
Contributor
SimonFrings
left a comment
SimonFrings
left a comment
There was a problem hiding this comment.
It appears that we're still using the old ubuntu-20.04 in our PHPUnit job within the ci.yml file. I believe this should also be updated to ubuntu-22.04, just like you did for the PHPUnit-hhvm job.
SimonFrings
added
documentation
Contributor
Author
|
Tysm @SimonFrings for sharpening my eyes for this ! I totally didn't saw this in the first place. Whoops. But it should be alright now! 🥳 |
SimonFrings
approved these changes
Nov 14, 2023
Contributor
SimonFrings
left a comment
SimonFrings
left a comment
There was a problem hiding this comment.
Thanks for applying the changes, looking good 👍
This was referenced Dec 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request builds on top of #46, #47 and #48.
References: clue/reactphp-csv#33, reactphp/socket#300 and reactphp/socket#299.
After this pull request is merged, we can continue with #53.