fix: Scope Wizard test utility findMenuNavigationLinks to sidebar navigation#4286
Merged
fix: Scope Wizard test utility findMenuNavigationLinks to sidebar navigation#4286
Conversation
pan-kot
previously approved these changes
Feb 24, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4286 +/- ##
=======================================
Coverage 97.42% 97.42%
=======================================
Files 891 891
Lines 26098 26098
Branches 9435 9435
=======================================
Hits 25426 25426
Misses 629 629
Partials 43 43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pan-kot
approved these changes
Feb 24, 2026
pan-kot
reviewed
Feb 24, 2026
|
|
||
| findMenuNavigationLinks(): Array<ElementWrapper> { | ||
| return this.findAllByClassName(styles['navigation-link']); | ||
| return this.findByClassName(styles.navigation)!.findAllByClassName(styles['navigation-link']); |
Member
There was a problem hiding this comment.
The navigation is always present, right - including mobile viewport?
Member
Author
There was a problem hiding this comment.
Yes, the sidebar <nav> with .navigation class is always in the DOM. It's never conditionally rendered. On small containers it's CSS-hidden (display: none) but still present, so findByClassName will always find it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After the introduction of the expandable step navigation (#4200),
findMenuNavigationLinks()returns double the expected number of links. Both the desktop sidebar and the mobile expandable navigation render navigation links with the same CSS class in the DOM. SincefindAllByClassNamesearches the entire component tree, it picks up links from both navigations.This scopes
findMenuNavigationLinks()andfindMenuNavigationLink()to only search within the sidebar<nav>element (.navigationclass), restoring backward-compatible behavior.Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.