refactor: use native padStart() in padLeftZeros utility#4202
Merged
pan-kot merged 2 commits intocloudscape-design:mainfrom Jan 29, 2026
Merged
Conversation
Replace manual while loop with String.prototype.padStart() for cleaner, more idiomatic code. This native ES2017 method provides the same functionality with better readability.
pan-kot
approved these changes
Jan 29, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4202 +/- ##
==========================================
- Coverage 97.17% 97.17% -0.01%
==========================================
Files 882 882
Lines 25826 25824 -2
Branches 9333 9333
==========================================
- Hits 25097 25095 -2
Misses 682 682
Partials 47 47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
via the queue into
cloudscape-design:main
with commit Jan 29, 2026
170fdf8
47 of 48 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces a
whileloop with padStart for cleaner, more idiomatic code. ThepadStartmethod has been widely supported for several years now.How has this been tested?
This utility function has extensive unit test coverage.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.