Open
Conversation
✅ Deploy Preview for cld-vp-esm-pages ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cld-video-player ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tsi
reviewed
Feb 16, 2026
Collaborator
tsi
left a comment
tsi
left a comment
There was a problem hiding this comment.
Great work! 💪 please see my comments
| if (!breakpointsEnabled) return null; | ||
|
|
||
| // Get player element from DOM | ||
| const playerElement = document.querySelector('.cld-video-player, video.vjs-tech'); |
Collaborator
There was a problem hiding this comment.
We shouldn't trust a DOM query here, we should have explicit reference to the current player.
Please see how we set the size for the poster image (in cloudinary plugin) and see if this will work for this too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements automatic video resolution selection based on container width and device pixel ratio (DPR).