Don't leak unconsumed deferreds in error state in HTTP client #767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerGuteMoritz
force-pushed
the
fix-766
branch
from
69bc640 to
b4d0991
Compare
DerGuteMoritz
changed the title
DerGuteMoritz
force-pushed
the
fix-766
branch
from
b4d0991 to
2affe03
Compare
DerGuteMoritz
force-pushed
the
fix-766
branch
from
529209c to
1c04919
Compare
Fixes various error deferred leaks originating in Manifold itself.
To that end, turn `wrap-exceptions` from a wrapping middleware into an "after handler" (like `handle-redirects`) called `handle-error-status`. This also happens to improve a suboptimal behavior: When a request with `:throw-exceptions? true` was made and an error response was received which the middleware would turn into an exception, the underlying connection would be closed regardless of whether the response indicated keep-alive or not.
Turns out the custom pool wasn't actually used!
We breached the default of 10 minutes a few times now
DerGuteMoritz
force-pushed
the
fix-766
branch
4 times, most recently
from
1c5fc46 to
c87dd2e
Compare
Enabling both Netty's resource leak detection and Manifold's dropped error deferred detection at the same time makes the test suite so slow that we breach CircleCI's timeout of 60 minutes.
Turns out CircleCI's 60 minutes timeout applies to the overall job, not just per step. Thus, split the test runs up into separate jobs so that they both get 60 minutes. This has the additional advantage that they will run in parallel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #766
See individual commits for details.