Skip to content

feat: add check ELF alignment command#686

Merged
thymikee merged 1 commit intocallstackincubator:mainfrom
LukasMod:feat/elf-alignment-check
Feb 16, 2026
Merged

feat: add check ELF alignment command#686
thymikee merged 1 commit intocallstackincubator:mainfrom
LukasMod:feat/elf-alignment-check

Conversation

@LukasMod
Copy link
Contributor

@LukasMod LukasMod commented Feb 4, 2026

@vercel
Copy link

vercel bot commented Feb 4, 2026

@LukasMod is attempting to deploy a commit to the Callstack Team on Vercel.

A member of the Team first needs to authorize it.

@thymikee
Copy link
Contributor

what's the status here @LukasMod, do we still need this?
FYI we've added ELF alignment (as part of 16kb verification checks) as a skill to callstackincubator/agent-skills

@LukasMod
Copy link
Contributor Author

LukasMod commented Feb 13, 2026

@thymikee Yup, I had few more prio issues and switching back to this one. I want to do some tests with it locally first. I will check it, thank you

@LukasMod LukasMod force-pushed the feat/elf-alignment-check branch 4 times, most recently from 6cc4d3f to 63c5ef7 Compare February 16, 2026 12:06
@thymikee
Copy link
Contributor

Um, can't we ask users to run the script themselves since Google provides it? This is what we recommend in our agent-skills

@LukasMod
Copy link
Contributor Author

The idea was to keep this within the CI process where we already build the .apk, so we can catch potential regressions early. Cases where the app builds successfully, but Google later rejects the upload. I wanted to avoid creating a separate build step just for that validation, since everything related to building already lives inside the rock step and this way its just faster to reuse already created files and validate them before uploading to cache.

@thymikee thymikee merged commit 1db5743 into callstackincubator:main Feb 16, 2026
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants