wasip3 filesystem unlink: Homogenize error returns #12169
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wingo
force-pushed
the
canonicalize-unlink-dir-errors
branch
from
d3f4a32 to
1c1bdbb
Compare
Contributor
Author
|
Seems this fails wasip1 tests which do want to assert that the error is |
wingo
force-pushed
the
canonicalize-unlink-dir-errors
branch
from
1c1bdbb to
3b8ab4a
Compare
When attempting to unlink a directory, POSIX specifies the result should be EPERM, but only MacOS implements that behavior. Paper over the differences. Also turn EACCESS into EPERM, to paper over Windows differences. Related to WebAssembly/WASI#852 and WebAssembly/wasi-testsuite#137. POSIX 2008 reference: https://pubs.opengroup.org/onlinepubs/9699919799/functions/unlink.html
wingo
force-pushed
the
canonicalize-unlink-dir-errors
branch
from
3b8ab4a to
6f80454
Compare
fitzgen
added
wasi:impl
Member
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
Thanks! Could this have a test here as well? Also, could this be done around here to apply to wasip{1,2,3} uniformly instead of just wasip3?
Contributor
Author
|
I originally did it on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to unlink a directory, POSIX specifies the result should be EPERM, but only MacOS implements that behavior. Paper over the differences. Also turn EACCESS into EPERM, to paper over Windows differences.
Related to WebAssembly/WASI#852 and WebAssembly/wasi-testsuite#137.
POSIX 2008 reference: https://pubs.opengroup.org/onlinepubs/9699919799/functions/unlink.html