Merged
Conversation
A couple of comments weren't detailed enough, they passed the linting checks but future visitors could do with more context
Linting failed due to an unformatted file.
Testing to see if the secrets need to be passed to the container running goreleaser
scadu
reviewed
Feb 5, 2026
Localhost bad
JoeColeman95
previously approved these changes
Feb 5, 2026
Contributor
|
Looks great 🔒 |
We were disgarding `result` which would cause a nil pointer
JoeColeman95
requested changes
Feb 5, 2026
Co-authored-by: Joe Coleman <107399878+JoeColeman95@users.noreply.github.com>
Co-authored-by: Joe Coleman <107399878+JoeColeman95@users.noreply.github.com>
JoeColeman95
previously approved these changes
Feb 5, 2026
Contributor
JoeColeman95
left a comment
JoeColeman95
left a comment
There was a problem hiding this comment.
Approving as last outstanding is not breaking and can be iterated on if needed
Implements use of `sync.Once` so that we don't need to use expensive I/O operations. Additionally removes the need for `CI=true` as `keyring` has a `MockForTesting` interface available. Appended a random suffix to test keys to avoid clashes.
JoeColeman95
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements OAuth support via
bk auth login.Changes
OAUTH_CLIENT_IDto pipeline (and in Cluster secrets).goreleaserto support injection of OAuth Client ID in built binariesloginandlogoutsubcommands toauthrootbk auth login&bk auth logoutauthalias forconfigure(that was temporary anyway)Testing
go test ./...)go fmt ./...)Caveats
Still to come; removing tokens from text-based config.
Disclosures / Credits
I had used Claude to implement the OAuth endpoint in bk/bk due to my lack of Rails experience, so I consulted with it to ensure the implementation approach for the CLI would be in line, functionally, with how the bk/bk OAuth was built.