Open
Conversation
philrz
previously approved these changes
Feb 27, 2026
book/src/command/options.md
Outdated
| * `-signals` catch `SIGINT`, `SIGTERM`, and `SIGPIPE` and exit gracefully | ||
| * `-version` print version and exit | ||
|
|
||
| The `-signals` option is off by default except for `super db serve`, which always enables |
Contributor
There was a problem hiding this comment.
Suggested change
| The `-signals` option is off by default except for `super db serve`, which always enables | |
| The `-signals` option is off by default except for [super db serve](db.md#super-db-serve), which always enables |
book/src/command/options.md
Outdated
|
|
||
| The `-signals` option is off by default except for `super db serve`, which always enables | ||
| the catching of `SIGINT` and `SIGTERM` (but not `SIGPIPE`). When `-signals` is enabled, | ||
| the `super` command is interrupted but continues to a natural stopping point (e.g., flushing partial output files, removing spill file from temp). In the current implementation, |
Contributor
There was a problem hiding this comment.
Suggested change
| the `super` command is interrupted but continues to a natural stopping point (e.g., flushing partial output files, removing spill file from temp). In the current implementation, | |
| the `super` command is interrupted but continues to a natural stopping point (e.g., flushing partial output files and removing spill files from temporary storage). In the current implementation, |
book/src/command/options.md
Outdated
| the catching of `SIGINT` and `SIGTERM` (but not `SIGPIPE`). When `-signals` is enabled, | ||
| the `super` command is interrupted but continues to a natural stopping point (e.g., flushing partial output files, removing spill file from temp). In the current implementation, | ||
| this can be unpredictably long so the default is to exit immediately, | ||
| potentially leaving behind corrupt outputs etc. |
Contributor
There was a problem hiding this comment.
Suggested change
| potentially leaving behind corrupt outputs etc. | |
| potentially leaving behind corrupt outputs, etc. |
philrz
dismissed
their stale review
Oops! I was clicking Approve based on the docs changes, but clearly someone else needs to approve the code changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.