[voronoi] Fixed a bug with color_exterior()#60
Open
eadf wants to merge 2 commits intoboostorg:developfrom
Open
[voronoi] Fixed a bug with color_exterior()#60eadf wants to merge 2 commits intoboostorg:developfrom
eadf wants to merge 2 commits intoboostorg:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a situation where
voronoi_visualizer.cppwould fail to mark some edges as external:The problem is that
color_exterior()sometimes starts with a terminating edgev1()==NULLand marks that edge and the twin as external.When
color_exterior()is called again, this time on the twin edge that is leading away from infinity, it finds the edge already marked and terminates recursion.This could also be solved on the calling side: