Parser.consume

[klemens-morgenstern]

I want to write a stream API for http.

I will also need a buffer to reset a previously returned buffer from a body-writer.

[vinniefalco]

This is a breaking API change...

[klemens-morgenstern]

Yes, and one that is overdue.

[vinniefalco]

The meaning of the return value used to be different from what it is now. We changed it because of user requests. If we change it again, then we are breaking those users.

[ashtum]

The meaning of the return value used to be different from what it is now. We changed it because of user requests. If we change it again, then we are breaking those users.

Wasn't that for async_read_some? #1942

[vinniefalco]

Maybe. I think you should decide if this is a good change. And if not, what else we might do (if anything).

[codecov]

Codecov Report

Attention: Patch coverage is 97.59036% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.08%. Comparing base (fee9be0) to head (83725e0).
Report is 62 commits behind head on develop.

Files with missing lines	Patch %	Lines
include/boost/beast/http/impl/serializer.hpp	97.22%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2913      +/-   ##
===========================================
- Coverage    93.09%   93.08%   -0.02%     
===========================================
  Files          177      177              
  Lines        13709    13773      +64     
===========================================
+ Hits         12763    12821      +58     
- Misses         946      952       +6     

Files with missing lines	Coverage Δ
include/boost/beast/core/buffers_cat.hpp	100.00% <100.00%> (ø)
include/boost/beast/core/buffers_suffix.hpp	100.00% <100.00%> (ø)
include/boost/beast/http/impl/write.hpp	92.13% <100.00%> (+0.06%)	⬆️
include/boost/beast/http/serializer.hpp	90.90% <ø> (ø)
include/boost/beast/http/impl/serializer.hpp	91.48% <97.22%> (+1.13%)	⬆️

... and 1 file with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fee9be0...83725e0. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.