-
Notifications
You must be signed in to change notification settings - Fork 1
Fixing #6 #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…spection at fastkit cli(developer mode)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses issue #6 by adding structured debug logging throughout the template inspection process and improving error message formatting for better traceability. It also updates the CI workflow to ensure Docker Compose is available and enables verbose output.
- Consolidated error and warning handling by introducing
error_msg/warning_msgvariables and usingdebug_logcalls. - Enhanced inspection methods (
_check_*, testing, Docker steps) with debug-level and severity-specific logs. - Modified the GitHub Actions workflow to grant permissions, install Docker Compose when missing, and pass
--verboseto the inspection script.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/fastapi_fastkit/backend/inspector.py | Added debug_log calls after appending errors/warnings, refactored report generation logging |
| .github/workflows/template-inspection.yml | Granted extra permissions, added Docker Compose install step, and switched inspection to verbose mode |
Comments suppressed due to low confidence (3)
.github/workflows/template-inspection.yml:38
- [nitpick] Some Docker installations use the
docker composesubcommand rather than a separatedocker-composebinary. Consider also checking fordocker composeto improve compatibility.
if ! command -v docker-compose &> /dev/null; then
src/fastapi_fastkit/backend/inspector.py:224
- New
debug_logcalls have been added but there are no tests ensuring these logs are emitted. Consider adding tests to verify debug logging behavior on both success and failure paths, and validate the--verboseflag in the inspection script.
debug_log(f"File structure check failed: {error_msg}", "error")
src/fastapi_fastkit/backend/inspector.py:222
- [nitpick] The pattern of assigning
error_msg, appending toself.errors, and callingdebug_logis repeated across multiple methods. Consider extracting this into a helper method (e.g.,_record_error) to reduce duplication and improve maintainability.
error_msg = f"Missing required path: {path}"
|
|
||
| permissions: | ||
| contents: read | ||
| issues: write |
Copilot
AI
Jul 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow grants write access to issues but does not interact with issues in this job. Remove or narrow the issues: write permission to follow the principle of least privilege.
| issues: write |
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Requesting Merging
Description
Fixing #6
Type of Change
Test Environment
localhost, MacOS M1
Major Changes
Screenshots (optional)
Etc