implement aliases for npm lock files#1689
Open
dterrybd wants to merge 1 commit intodev/dterry/IDETECT-4965-npm-alias-featurefrom
Open
implement aliases for npm lock files#1689dterrybd wants to merge 1 commit intodev/dterry/IDETECT-4965-npm-alias-featurefrom
dterrybd wants to merge 1 commit intodev/dterry/IDETECT-4965-npm-alias-featurefrom
Conversation
dterrybd
requested review from
bd-samratmuk,
devmehtabd,
shantyk and
zahidblackduck
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes build upon the CLI and package JSON npm alias changes. They handle the shrinkwrap and lock file Detectors.
Thre is a bit of refactoring so that a common NpmAliasParser utility can
- Detects if a package name is an alias (format: "npm:actual-package@version")
- Extracts the real package name from alias syntax
This leverages the alias mapping built by previous CLI and package JSON detectors on this feature branch.
This mapping is passed through the lock file graph transformer to correctly resolve aliased packages when building the dependency graph