Skip to content

Add comments explaining why the reloading code is so complex. #22264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alice-i-cecile merged 1 commit into from
Dec 29, 2025
Merged

Add comments explaining why the reloading code is so complex. #22264

alice-i-cecile merged 1 commit into from
Dec 29, 2025

Conversation

@andriyDev
Copy link
Contributor

@andriyDev andriyDev commented Dec 25, 2025

Objective

Solution

  • Give an explanation, and add a TODO. Note I didn't write this code, so I'm "guessing" on the rationale - but it's an educated guess!

@andriyDev andriyDev added C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy A-Assets Load files from disk to use for things like images, models, and sounds S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 25, 2025
@alice-i-cecile alice-i-cecile requested a review from cart December 25, 2025 01:09
@alice-i-cecile alice-i-cecile added D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes and removed D-Trivial Nice and easy! A great choice to get started with Bevy labels Dec 25, 2025
@ChristopherBiscardi ChristopherBiscardi added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 25, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 29, 2025
Merged via the queue into bevyengine:main with commit 0a2e645 Dec 29, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@cart cart Awaiting requested review from cart

+1 more reviewer

@ChristopherBiscardi ChristopherBiscardi ChristopherBiscardi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Assets Load files from disk to use for things like images, models, and sounds C-Docs An addition or correction to our documentation D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Logic in reload_internal is confusing and needs to be commented

3 participants

@andriyDev @ChristopherBiscardi @alice-i-cecile