-
Notifications
You must be signed in to change notification settings - Fork 17
Cleanup and use BEMAN_HAS_MODULES in code #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup and use BEMAN_HAS_MODULES in code #206
Conversation
|
@dietmarkuehl but some tests fails to build with only this tests fail to compile: |
CMakeLists.txt
Outdated
| ${CMAKE_CURRENT_BINARY_DIR}/beman/execution/modules_export.hpp | ||
| ) | ||
| target_compile_definitions(beman_execution PUBLIC BEMAN_USE_MODULES) | ||
| target_compile_definitions(beman_execution PUBLIC BEMAN_HAS_MODULES) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dietmarkuehl I may comment this out for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge the PR onto the branch about nowish. ... and I can comment that line out if that is all what's needed. On the other hand, I want to make sure I test module building when meddling with the script.
Create and install an interface libray and the
CXX_MODULEif possibleAvailable CMake options:
Exported CMake targets:
Installed CMAKE config package:
bash-5.3$ cpack CPack: Create package using TGZ CPack: Install projects CPack: - Install project: beman_execution [] CPack: Create package CPack: - package: gcc-release/beman_execution-0.0.1-Darwin.tar.gz generated. bash-5.3$ tree _CPack_Packages/Darwin/TGZ/beman_execution-0.0.1-Darwin/lib/cmake/ _CPack_Packages/Darwin/TGZ/beman_execution-0.0.1-Darwin/lib/cmake/ └── beman_execution ├── beman_execution-config-targets-relwithdebinfo.cmake ├── beman_execution-config-targets.cmake ├── beman_execution-config-version.cmake ├── beman_execution-config.cmake ├── cxx-modules-beman_execution-config-targets-RelWithDebInfo.cmake ├── cxx-modules-beman_execution-config-targets.cmake ├── module │ └── execution.cppm └── target-beman__execution-RelWithDebInfo.cmake 3 directories, 8 files bash-5.3$