Install header only library and cxx_module lib #205
+405
−109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClausKlein
requested review from
camio,
dietmarkuehl and
neatudarius
as code owners
Member
dietmarkuehl
left a comment
dietmarkuehl
left a comment
There was a problem hiding this comment.
On the branch I had meddled a bit and fixed a bunch of things to fix some problems in the code. To get the code to compile I did change in particular examples/modules.cpp.
ClausKlein
commented
Jan 29, 2026
ClausKlein
commented
Jan 29, 2026
ClausKlein
force-pushed
the
feature/install-header-only-lib-too
branch
from
fc4afe4 to
fc741e7
Compare
Prevent build errors with appleclang too
Quickfix: use import beman.execution; Show #warning if __cpp_modules is not set right Quickfix: do not compile examles/modules.cpp yet
ClausKlein
force-pushed
the
feature/install-header-only-lib-too
branch
from
fc741e7 to
099d115
Compare
ClausKlein
commented
Jan 29, 2026
|
|
||
| if(BEMAN_USE_MODULES) | ||
| list(APPEND EXAMPLES modules) # modules.cpp | ||
| # FIXME: not yet! list(APPEND EXAMPLES modules) # modules.cpp |
ClausKlein
commented
Jan 29, 2026
Comment on lines
+198
to
211
| set(TARGET_LIST ${TARGET_NAME}) | ||
|
|
||
| if(BEMAN_USE_MODULES) | ||
| target_sources( | ||
| ${TARGET_NAME} | ||
| beman_execution | ||
| PRIVATE execution.cpp | ||
| PUBLIC | ||
| FILE_SET CXX_MODULES | ||
| BASE_DIRS ${PROJECT_SOURCE_DIR}/src/beman/execution | ||
| FILES ${PROJECT_SOURCE_DIR}/src/beman/execution/execution.cppm | ||
| ) | ||
| target_link_libraries(beman_execution PUBLIC ${TARGET_NAME}) | ||
| list(APPEND TARGET_LIST beman_execution) | ||
| endif() |
Collaborator
Author
There was a problem hiding this comment.
@dietmarkuehl I create and install a beman_execution and a beman_execution_headers only lib now
ClausKlein
commented
Jan 29, 2026
Comment on lines
116
to
126
| if(BEMAN_USE_MODULES) | ||
| target_compile_definitions(${TARGET_NAME} PUBLIC BEMAN_USE_MODULES) | ||
| target_link_libraries(${TEST_EXE} PRIVATE beman::execution) | ||
| else() | ||
| target_link_libraries(${TEST_EXE} PRIVATE beman::execution_headers) | ||
| endif() | ||
| target_link_libraries(${TEST_EXE} PRIVATE beman::execution) |
Collaborator
Author
There was a problem hiding this comment.
@dietmarkuehl this are the ALIAS and the IMPORTED libraries!
Member
There was a problem hiding this comment.
That makes sense. Now I also understand the copilot comment on that and why my tests gave the impression to work with modules although I think they shouldn’t.
ClausKlein
commented
Jan 29, 2026
Comment on lines
+102
to
+105
| include(infra/cmake/beman-install-library-config.cmake) | ||
| # FIXME: install TARGETS target beman.execution is exported but not all of its interface file sets are installed | ||
| # TODO: beman_install_library(beman_execution beman_execution_headers) | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
@ednolan How to install a project like execution with this CMake module?
Collaborator
Author
|
@dietmarkuehl we need something like this: diff --git a/include/beman/execution/detail/common.hpp b/include/beman/execution/detail/common.hpp
index eec0f2c..36d7c0f 100644
--- a/include/beman/execution/detail/common.hpp
+++ b/include/beman/execution/detail/common.hpp
@@ -6,7 +6,13 @@
// ----------------------------------------------------------------------------
+#if __has_include (<beman/execution/modules_export.hpp>)
+#include <beman/execution/modules_export.hpp>
+#endif
+
+#ifndef BEMAN_EXECUTION_EXPORT
#define BEMAN_EXECUTION_EXPORT
+#endif
#if defined(disabled__cpp_deleted_function)
#define BEMAN_EXECUTION_DELETE(msg) delete (msg) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create and install an interface libray and
CXX_MODULEAvailable CMake options:
Exported CMake targets:
Installed CMAKE config package:
bash-5.3$ cpack CPack: Create package using TGZ CPack: Install projects CPack: - Install project: beman_execution [] CPack: Create package CPack: - package: gcc-release/beman_execution-0.0.1-Darwin.tar.gz generated. bash-5.3$ tree _CPack_Packages/Darwin/TGZ/beman_execution-0.0.1-Darwin/lib/cmake/ _CPack_Packages/Darwin/TGZ/beman_execution-0.0.1-Darwin/lib/cmake/ └── beman_execution ├── beman_execution-config-targets-relwithdebinfo.cmake ├── beman_execution-config-targets.cmake ├── beman_execution-config-version.cmake ├── beman_execution-config.cmake ├── cxx-modules-beman_execution-config-targets-RelWithDebInfo.cmake ├── cxx-modules-beman_execution-config-targets.cmake ├── module │ └── execution.cppm └── target-beman__execution-RelWithDebInfo.cmake 3 directories, 8 files bash-5.3$examles/modules.cppWorks on my iMAC with
gcc-15andllvm-21withCMakeUserPresets.json -> cmake/CMakeUserPresets.json