Feature/ab#30835 connect ai agent #1886
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced OpenAI summary generation with a new method that calls the Agentic AI API using a resilient HTTP request. - Updated relevant methods to use GenerateAgenticSummaryAsync for improved reliability and consistency.
-sonarqube fix
…aryAsync - Added AGENTIC_AI key to DynamicUrlKeyNames and seeded its default value in DynamicUrlDataSeeder. - Updated OpenAIService to retrieve the Agentic AI endpoint dynamically via IEndpointManagementAppService and refactored related method calls to use the standard summary generation method.
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
Comment on lines
+22
to
+37
| private readonly IResilientHttpRequest _resilientHttpRequest; | ||
| private readonly IEndpointManagementAppService _endpointManagementAppService; | ||
|
|
||
| private string? ApiKey => _configuration["AI:OpenAI:ApiKey"]; | ||
| private string? ApiUrl => _configuration["AI:OpenAI:ApiUrl"] ?? "https://api.openai.com/v1/chat/completions"; | ||
| private readonly string NoKeyError = "OpenAI API key is not configured"; | ||
| private readonly string NoSummaryMsg = "No summary generated."; | ||
|
|
||
| public OpenAIService(HttpClient httpClient, IConfiguration configuration, ILogger<OpenAIService> logger, ITextExtractionService textExtractionService) | ||
| public OpenAIService(HttpClient httpClient, IConfiguration configuration, ILogger<OpenAIService> logger, ITextExtractionService textExtractionService, IResilientHttpRequest resilientHttpRequest, IEndpointManagementAppService endpointManagementAppService) | ||
| { | ||
| _httpClient = httpClient; | ||
| _configuration = configuration; | ||
| _logger = logger; | ||
| _textExtractionService = textExtractionService; | ||
| _resilientHttpRequest = resilientHttpRequest; | ||
| _endpointManagementAppService = endpointManagementAppService; |
There was a problem hiding this comment.
The new dependencies IResilientHttpRequest and IEndpointManagementAppService are only used in the private unused method GenerateAgenticSummaryAsync. Since this method is not called anywhere, these dependencies are effectively unused, increasing the complexity of the constructor and dependency injection without providing any current value. Consider removing these dependencies until the Agentic AI functionality is actually implemented and used.
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
ligovbc
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.