Open
Conversation
konraddysput
requested changes
Dec 1, 2022
vlussenburg
commented
Dec 5, 2022
vlussenburg
commented
Dec 5, 2022
example-app/src/main/java/backtraceio/backtraceio/MainActivity.java
Outdated
Show resolved
Hide resolved
konraddysput
reviewed
Dec 7, 2022
KrzaQ
suggested changes
Dec 8, 2022
Contributor
KrzaQ
left a comment
KrzaQ
left a comment
There was a problem hiding this comment.
I think the change looks well overall, but some things should be more fleshed out before we release it to the public.
|
|
||
| // Start crash handler | ||
| client = new crashpad::CrashpadClient(); | ||
| client->EnableCrashLoopDetection(); |
Contributor
There was a problem hiding this comment.
I'm wondering if we want to make this configurable for the end-users.
Collaborator
There was a problem hiding this comment.
i think we should - imo we should pass it and don't execute this path if we don't need it. By default we want have features opt-in
There was a problem hiding this comment.
removed it - it is called from Example's MainActivity now.
example-app/src/main/java/backtraceio/backtraceio/MainActivity.java
Outdated
Show resolved
Hide resolved
This reverts commit 3480c11.
example-app/src/main/java/backtraceio/backtraceio/MainActivity.java
Outdated
Show resolved
Hide resolved
KrzaQ
suggested changes
Feb 10, 2023
Contributor
KrzaQ
left a comment
KrzaQ
left a comment
There was a problem hiding this comment.
We need to update the crashpad dependency for a fix that has yet to be done. I'm on it, but this must wait.
example-app/src/main/java/backtraceio/backtraceio/MainActivity.java
Outdated
Show resolved
Hide resolved
* Backtrace client api improvements * Bring back backtrace credentials definition
konraddysput
approved these changes
Feb 14, 2023
Contributor
|
Please rebase the branch on the latest master branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopening #71