Fix (oauth2): enforce owner-scoped PAT deletion#32
Closed
KevinRoebert wants to merge 1 commit intoayaka-notes:server-profrom
Closed
Fix (oauth2): enforce owner-scoped PAT deletion#32KevinRoebert wants to merge 1 commit intoayaka-notes:server-profrom
KevinRoebert wants to merge 1 commit intoayaka-notes:server-profrom
Conversation
Member
|
Thanks for your contribution ! |
Member
|
We will merge this in #33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an authorization gap in PAT deletion by enforcing token ownership at deletion time.
Changes
removeTokento require bothtokenIdanduserId._id = tokenIduser_id = userIdtype = personal_access_tokentokenIdhandling withObjectId.isValid(...)to avoid deletion attempts on malformed IDs.user._idintoremoveToken(...)404 Token not foundwhen no owned token is deleted (deletedCount !== 1)Security Impact