ci: update clang format version #5661
Open
+8
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boquan-fang
approved these changes
Dec 10, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Move the clang format CI job off the old forked GHA and upgrade to a newer version
Why
I ran into a clang-format failure while working on #5657. My local branch did not catch the errors because it is using clang-format-18 while the CI job ran on an older version v15. The GHA harrisonkaiser/clang-format-action does not support versions above 15. Thus I attempted to replace it with the parent repo jidicula/clang-format-action that is more up-to-date and supports newer versions. Unfortunately, 3 other files failed the check of clang-format-18.
Given that getting off of custom forks is usually the best practice, this PR will deprecate the old GHA and bump the clang format version.
How
Replace the forked GHA with the parent repo, upgrade the clang-format version to 18, and fix the discovered errors.
Testing
CI should pass
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.