Fix idle shutdown from happening when active process is still running #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--------- Co-authored-by: Newton Der <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description of Changes
Problem:
If user starts a process in the Terminal and closes the browser tab, the SageMaker Code Editor space will still automatically shut down after the idle timeout.
Explanation:
The
sagemaker-idle-extension'scheckTerminalActivitymethod halts when the browser tab is closed. Thus, it is unable to detect any running processes and avoid the idle timeout.Solution:
Moves
sagemaker-idle-extension'scheckTerminalActivitymethod to server side inwebClientServer. This method is called in the/api/idlehandler, which currently happens on a 1 minute interval.Testing
Tested with a custom image deployed in a SageMaker AI Studio domain.
Screenshots/Videos
Additional Notes
This same fix is already launched and working in
sagemaker-code-editorversions 1.5, 1.6, and 1.7.Backporting
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.