feat: add --resolve-image-repos support to sam package #8476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements issue aws#3888 to auto-create ECR repositories during packaging, matching sam deploy behavior. Enables package-once, deploy-many CI/CD workflows with managed ECR repos. - Add --resolve-image-repos CLI option to sam package - Call sync_ecr_stack() to auto-create managed ECR repositories - Add validation requiring --s3-bucket when flag is used - Add conflict detection with --image-repositories - Add unit tests for validation logic Closes aws#3888
github-actions
bot
added
area/package
vicheey
requested changes
Dec 5, 2025
Contributor
vicheey
left a comment
vicheey
left a comment
There was a problem hiding this comment.
Thank you for your contribution. Since this is a remote operation, do you mind add integration test as well.
| super().__init__(message=message_fmt) | ||
|
|
||
|
|
||
| class PackageResolveImageReposAndImageReposSetError(UserException): |
Contributor
There was a problem hiding this comment.
I do not see this class being used anywhere.
Author
There was a problem hiding this comment.
Ah!, my apologies I implemented this class to check exceptions in my testing, but I haven't included my testing files in here so the reason why this class is unused in the PR.
| Execute packaging based on the argument provided by customers and samconfig.toml. | ||
| """ | ||
| if self.resolve_image_repos: | ||
| from samcli.lib.bootstrap.companion_stack.companion_stack_manager import sync_ecr_stack |
Contributor
There was a problem hiding this comment.
Following the existing pattern, the import should be at the top of the file.
Author
There was a problem hiding this comment.
I have updated this PR now, and made this above change. I have also added the integration tests with this update.
…add integration test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements
--resolve-image-repossupport forsam packagecommand to automatically create ECR repositories, matching the behavior ofsam deploy.Resolves
Closes #3888
Changes
--resolve-image-reposCLI option tosam packagesync_ecr_stack()to auto-create managed ECR repositories--s3-bucketwhen flag is used--image-repositoriesTesting
Use Case
Enables CI/CD workflows to package once and deploy to multiple environments in parallel using AWS-managed ECR repositories, avoiding manual repo creation and permission complexity.