chore: add timeout to tests and print stacktrace #1062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faviansamatha
commented
Dec 19, 2025
| Long exitCode = execInContainer(container, consumer, | ||
| "poetry", "run", "pytest", "-vvvvv", reportSetting, "-k", config.testFilter, | ||
| "-p", "no:logging", "--capture=tee-sys", testFolder); | ||
| "--timeout=600", "--tb=long", "--timeout-method=thread","-p", "no:logging", |
Contributor
Author
There was a problem hiding this comment.
Ideally, timeout should be configurable in the test framework, but let's do that in another task.
Contributor
There was a problem hiding this comment.
Agreed. Should we make a ticket to track it or are you thinking of doing it soon?
sophia-bq
approved these changes
Dec 19, 2025
| Long exitCode = execInContainer(container, consumer, | ||
| "poetry", "run", "pytest", "-vvvvv", reportSetting, "-k", config.testFilter, | ||
| "-p", "no:logging", "--capture=tee-sys", testFolder); | ||
| "--timeout=600", "--tb=long", "--timeout-method=thread","-p", "no:logging", |
Contributor
There was a problem hiding this comment.
Agreed. Should we make a ticket to track it or are you thinking of doing it soon?
faviansamatha
force-pushed
the
test/add-timeout
branch
from
e4d80bf to
f32d835
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
chore: add timeout to integration tests. The 600 second timeout is a timeout for a single test. If the test reaches this timeout, it will output the call stack. This is useful for debugging hanging tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.