Add HighSpeedInterconnectPlacement parameter to VMSS cmdlets #1
+218
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
HighSpeedInterconnectPlacementparameter toNew-AzVmssandNew-AzVmssConfigcmdlets for controlling Infiniband network interconnect on RDMA-capable VM sizes. Accepts values:NoneorTrunk.Changes:
PSVirtualMachineScaleSetmodelVirtualMachineScaleSetStrategy.csUsage:
Requirements:
VirtualMachineScaleSetmodelMandatory Checklist
General release
Public preview
Private preview
Engineering build
No need for a release
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
1n8vsblobprodwus2184.vsblob.vsassets.iodotnet build src/Compute/Compute/Compute.csproj -c Debug(dns block)40vvsblobprodwus2135.vsblob.vsassets.iodotnet build src/Compute/Compute/Compute.csproj -c Debug(dns block)6yfvsblobprodwus2121.vsblob.vsassets.iodotnet build src/Compute/Compute/Compute.csproj -c Debug(dns block)7q7vsblobprodwus2144.vsblob.vsassets.iodotnet build src/Compute/Compute/Compute.csproj -c Debug(dns block)84hvsblobprodwus2148.vsblob.vsassets.iodotnet build src/Compute/Compute/Compute.csproj -c Debug(dns block)8wdvsblobprodwus2137.vsblob.vsassets.iodotnet build src/Compute/Compute/Compute.csproj -c Debug(dns block)9yyvsblobprodwus2157.vsblob.vsassets.iodotnet build src/Compute/Compute/Compute.csproj -c Debug(dns block)b53vsblobprodwus2154.vsblob.vsassets.iodotnet build src/Compute/Compute/Compute.csproj -c Debug(dns block)ba0vsblobprodwus2130.vsblob.vsassets.iodotnet build src/Compute/Compute/Compute.csproj -c Debug(dns block)balvsblobprodwus2129.vsblob.vsassets.iodotnet build src/Compute/Compute/Compute.csproj -c Debug(dns block)cbvvsblobprodwus2131.vsblob.vsassets.iodotnet build src/Compute/Compute/Compute.csproj -c Debug(dns block)cffvsblobprodwus218.vsblob.vsassets.iodotnet build src/Compute/Compute/Compute.csproj -c Debug(dns block)d94vsblobprodwus2119.vsblob.vsassets.iodotnet build src/Compute/Compute/Compute.csproj -c Debug(dns block)ezcvsblobprodwus2170.vsblob.vsassets.iodotnet build src/Compute/Compute/Compute.csproj -c Debug(dns block)faxvsblobprodwus2122.vsblob.vsassets.iodotnet build src/Compute/Compute/Compute.csproj -c Debug(dns block)g3xvsblobprodwus2151.vsblob.vsassets.iodotnet build src/Compute/Compute/Compute.csproj -c Debug(dns block)i01vsblobprodwus216.vsblob.vsassets.iodotnet build src/Compute/Compute/Compute.csproj -c Debug(dns block)isvvsblobprodwus2147.vsblob.vsassets.iodotnet build src/Compute/Compute/Compute.csproj -c Debug(dns block)jhgvsblobprodwus2167.vsblob.vsassets.iodotnet build src/Compute/Compute/Compute.csproj -c Debug(dns block)k4pvsblobprodwus2140.vsblob.vsassets.iodotnet build src/Compute/Compute/Compute.csproj -c Debug(dns block)ldhvsblobprodwus2153.vsblob.vsassets.iodotnet build src/Compute/Compute/Compute.csproj -c Debug(dns block)mt2vsblobprodwus2110.vsblob.vsassets.iodotnet build src/Compute/Compute/Compute.csproj -c Debug(dns block)nudvsblobprodwus214.vsblob.vsassets.iodotnet build src/Compute/Compute/Compute.csproj -c Debug(dns block)p2tvsblobprodwus2189.vsblob.vsassets.iodotnet build src/Compute/Compute/Compute.csproj -c Debug(dns block)s8nvsblobprodwus2158.vsblob.vsassets.iodotnet build src/Compute/Compute/Compute.csproj -c Debug(dns block)tn2vsblobprodwus2124.vsblob.vsassets.iodotnet build src/Compute/Compute/Compute.csproj -c Debug(dns block)wlnvsblobprodwus2188.vsblob.vsassets.iodotnet build src/Compute/Compute/Compute.csproj -c Debug(dns block)wztvsblobprodwus2155.vsblob.vsassets.iodotnet build src/Compute/Compute/Compute.csproj -c Debug(dns block)y5lvsblobprodwus2179.vsblob.vsassets.iodotnet build src/Compute/Compute/Compute.csproj -c Debug(dns block)yf8vsblobprodwus212.vsblob.vsassets.iodotnet build src/Compute/Compute/Compute.csproj -c Debug(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
This section details on the original issue you should resolve
<issue_title>Add highSpeedInterconnectPlacement property in VMSS</issue_title>
<issue_description>
Guidelines
The purpose of the Azure PowerShell design review is to ensure that the cmdlets follow the same pattern across the Azure modules. An early design review reduces the risk of unnecessary implementation changes caused by a cmdlet syntax design change.
Please ensure your cmdlets comply with the design guidelines outlined in the PowerShell Design Guidelines document.
Please generate cmdlets syntax using
GenerateCmdletDesignMarkdown.ps1for review if your cmdlet is generated from API spec directly by Autorest.PowerShell.If you just add parameter to existing cmdlets and parameter definition complies with guideline, the design review is not expected.
Have you read above statement?
YesService Release Details
Is this an Embargoed Preview, A Public Preview, or a General Release?
General ReleaseWhat is the expected service release date?
{ EXPECTED RELEASE DATE HERE }Which Powershell module are these changes being made in?
Az.ComputeContact Information
Main developer contacts (emails + github aliases)
[email protected]PM contact (email + github alias)
NAOther people who should attend a design review (email)
NAHigh Level Scenarios
Describe how your feature is intended to be used by customers.
The HighSpeedInterconnectPlacement property allows customers to enable/opt out of Infiniband network interconnect between RDMA VM sizes.Piping scenarios / how these cmdlets are used with existing cmdlets
These are existing cmdlets and the new feature parameter will not change the piping scenarios.Sample of end-to-end usage
Syntax changes
Indicate if you are requesting an edit to existing cmdlets, adding new cmdlets, or both. Then edit the corresponding section below.
Expecting to add something like -HighSpeedInterconnectPlacement to the New-AvVMSS cmdlet:
Update the Full parameter set to add HighSpeedInterconnectPlacement