Refactor TypeScript profile codegen: typed helpers, reduced casts, resolved references#101
Merged
Refactor TypeScript profile codegen: typed helpers, reduced casts, resolved references#101
Conversation
Extract profile-helpers.ts into a static asset copied into generated output. Refactor validate helpers, extract slice match objects to static constants, replace inline slice logic with generic helpers, resolve profile references to base resource types, fix CCDA generation issues.
24a66ef to
1a58a26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
profile-helpers.tsruntime assetsetArraySlice,getArraySlice,ensureSliceDefaults)(res, profileName, ...)signaturestripMatchKeys,unwrapSliceChoice,ensurePath,ensureProfilehasMetacheck, base required fields, primitive types, reference varianceprofile-helpers.tsand section comments to generated classesSlice setters — match literals were duplicated in every method; now shared via static constants, reducing generated code size and making discriminators single-source-of-truth:
Validate — each helper had a different signature and mixed
string | nullreturns withstring[], making the generator emit inconsistent boilerplate; now all helpers share(res, profileName, field, ...) → string[]so the generator just spreads them:createResource — slice default logic was duplicated per-slice with inline match literals and manual array checks; now a single
ensureSliceDefaultscall handles any number of slices:🤖 Generated with Claude Code